add local abstract role usage warnings. fixes #1428 #1445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmacleod
reviewed
Apr 2, 2021
There was a problem hiding this comment.
Very nice! Just needs the old sentence in landmark role removed, and it's good to go!
Thanks, @jorycunningham !
Co-authored-by: Carolyn MacLeod <[email protected]>
carmacleod
approved these changes
Apr 8, 2021
|
(By the way, don't worry about PR Preview failing... it fails a lot). |
jnurthen
pushed a commit
that referenced
this pull request
May 6, 2021
* add local abstract role usage warnings. fixes #1428 Co-authored-by: Carolyn MacLeod <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1428
{role name}role in content." language to each role description.💥 Error: 500 Internal Server Error 💥
PR Preview failed to build. (Last tried on Apr 8, 2021, 7:55 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 HTML Diff Service - The HTML Diff Service is used to create HTML diffs of the spec changes suggested in a pull request.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.