add [CEReactions] to IDL.

[cookiecrook]

Resolves #1242

---

Diff

[cookiecrook]

cc @smaug----

[mrego]

JFYI, all implementations use CEReactions:

• Chromium: https://source.chromium.org/chromium/src/+/main:third_party/blink/renderer/core/dom/aria_attributes.idl
• WebKit: https://github.com/WebKit/blob/main/Source/WebCore/accessibility/AriaAttributes.idl
• Firefox:
  

  Copy link

  Contributor Author

  cookiecrook commented Jul 23, 2022

  @smaug----

  

  domenic approved these changes Jul 25, 2022

  View reviewed changes

  Copy link

  Contributor

  domenic left a comment

  Choose a reason for hiding this comment

  The reason will be displayed to describe this comment to others. Learn more.

  Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Hide comment

  LGTM, sorry for missing this.

  

  smaug---- approved these changes Aug 3, 2022

  View reviewed changes

  

  add xref HTML fro CEReactions reference

  a8dbc9d

  

  Copy link

  Contributor Author

  cookiecrook commented Aug 25, 2022

  Thanks all. @spectranaut I think this is ready to be merged.

  

  spectranaut approved these changes Aug 25, 2022

  View reviewed changes

  Copy link

  Contributor

  spectranaut left a comment

  Choose a reason for hiding this comment

  The reason will be displayed to describe this comment to others. Learn more.

  Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Hide comment

  Approving because all browsers implemented

  

  Copy link

  Contributor

  spectranaut commented Aug 25, 2022

  @pkra can you merge? :)

  pkra self-assigned this Aug 26, 2022

  jnurthen merged commit 483334d into main Aug 30, 2022

  github-actions bot added a commit that referenced this pull request Aug 30, 2022

  

  add [CEReactions] to IDL. (#1766) …

  9bf3ce5

  SHA: 483334d
  Reason: push, by @jnurthen
  
  Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

  pkra added the merge conflict with stable label Aug 31, 2022

  jnurthen pushed a commit that referenced this pull request Aug 31, 2022

  

  add [CEReactions] to IDL. (#1766) …

  2cd15a0

  * add [CEReactions] to IDL.
  Co-authored-by: James Nurthen <[email protected]>

  jnurthen removed the merge conflict with stable label Aug 31, 2022

  jnurthen pushed a commit that referenced this pull request Oct 10, 2023

  

  add [CEReactions] to IDL. (#1766) …

  e67bcea

  * add [CEReactions] to IDL.
  Co-authored-by: James Nurthen <[email protected]>

  Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

  Reviewers

  spectranaut spectranaut approved these changes

  domenic domenic approved these changes

  smaug---- smaug---- approved these changes

  aleventhal Awaiting requested review from aleventhal

  asurkov Awaiting requested review from asurkov

  Assignees

  pkra

  Labels

  None yet

  Projects

  None yet

  Milestone

  No milestone

  Development

  Successfully merging this pull request may close these issues.

  ARIA IDL miss CEReaction attribute

  7 participants

  

  Footer

  © 2025 GitHub, Inc.

  Footer navigation

  • Terms
  • Privacy
  • Security
  • Status
  • Docs
  • Contact
  • Manage cookies
  • Do not share my personal information

  Follow Lee on X/Twitter - Father, Husband, Serial builder creating AI, crypto, games & web tools. We are friends :) AI Will Come To Life!
  
  Check out: eBank.nz (Art Generator) | Netwrck.com (AI Tools) | Text-Generator.io (AI API) | BitBank.nz (Crypto AI) | ReadingTime (Kids Reading) | RewordGame | BigMultiplayerChess | WebFiddle | How.nz | Helix AI Assistant

[cookiecrook]

@smaug----

[domenic]

LGTM, sorry for missing this.

[cookiecrook]

Thanks all. @spectranaut I think this is ready to be merged.

[spectranaut]

Approving because all browsers implemented

[spectranaut]

@pkra can you merge? :)