-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change aria-errormessage to ID reference list #1802
Conversation
In Core-AAM it already has multiple references for IA2 and ATK/ATSPI. AX API (Mac) uses a text property and may not be able to support this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See also w3c/core-aam#138 to make core-aam align with this change
@jcsteh can you please take a look at this. |
Yes, WebKit could concatenate the text equivalents into the string for the API, or the API owners could consider a change. |
@jcsteh's review? I have a memory of discussing this in a meeting but I just looked through sept and oct meetings and didn't see anything. Should we agenda+ for a meeting in Jan, or do you remember discussing it? |
BTW, filled issues on Firefox. |
Needs WPT test and link to webkit issue before merging. |
WebKit already supports an ID reference list, so I guess we don't need an issue for that. |
…rorMessageElements This is WPT updates for w3c/aria#1802
Thanks web-platform-tests/wpt#37856 @spectranaut, I think this can be merged now? |
…rorMessageElements This is WPT updates for w3c/aria#1802
…rorMessageElements This is WPT updates for w3c/aria#1802
SHA: 11c8909 Reason: push, by spectranaut Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sorry I didn't get around to reviewing this before it was merged. FWIW, this looks good to me. |
…rorMessageElements (#37856) This is WPT updates for w3c/aria#1802
…rorMessageElement with ariaErrorMessageElements, a=testonly Automatic update from web-platform-tests Replace ARIA reflection attribute ariaErrorMessageElement with ariaErrorMessageElements (#37856) This is WPT updates for w3c/aria#1802 -- wpt-commits: b2408e7967806c7ad7691dae706f60ab463d17e6 wpt-pr: 37856
…rorMessageElement with ariaErrorMessageElements, a=testonly Automatic update from web-platform-tests Replace ARIA reflection attribute ariaErrorMessageElement with ariaErrorMessageElements (#37856) This is WPT updates for w3c/aria#1802 -- wpt-commits: b2408e7967806c7ad7691dae706f60ab463d17e6 wpt-pr: 37856
Supported starting in WAI-ARIA 1.3. w3c/aria#1802 Bug: 1403266 Change-Id: I5e3892e798f78acb8d99ff89d5bba76e12a9e2f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604466 Reviewed-by: David Tseng <[email protected]> Reviewed-by: Dominick Ng <[email protected]> Reviewed-by: Nektarios Paisios <[email protected]> Reviewed-by: Xiaocheng Hu <[email protected]> Commit-Queue: Aaron Leventhal <[email protected]> Reviewed-by: Anastasia Helfinstein <[email protected]> Cr-Commit-Position: refs/heads/main@{#1172297}
Fixes #1730.
Changes aria-errormessage to be an ID reference list
PR tracking
Implementation tracking
Diff