Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change aria-errormessage to ID reference list #1802

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

mrego
Copy link
Member

@mrego mrego commented Sep 15, 2022

Fixes #1730.

Changes aria-errormessage to be an ID reference list

PR tracking

  • Related Core AAM PR:
  • Related AccName PR:
  • Related APG PR:
  • Any other dependent changes?

Implementation tracking

  • validator tests
  • WPT tests: LINK
  • Browser implementations (link to issue or when done, link to commit):
    • WebKit: Implemented
    • Gecko: Implemented
    • Blink: ISSUE
  • Does this need AT implementations?

Diff

@cyns
Copy link
Contributor

cyns commented Sep 16, 2022

In Core-AAM it already has multiple references for IA2 and ATK/ATSPI.
Windows UI uses ControllerFor, which takes an array of references, so that can work

AX API (Mac) uses a text property and may not be able to support this.
@cookiecrook can this get text from multiple elements? Property: AXValidationError: textual content of the referenced element

cyns
Copy link
Contributor

@cyns cyns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also w3c/core-aam#138 to make core-aam align with this change

@jnurthen
Copy link
Member

@jcsteh can you please take a look at this.

@cookiecrook
Copy link
Contributor

cookiecrook commented Sep 29, 2022

AX API (Mac) uses a text property and may not be able to support this. @cookiecrook can this get text from multiple elements? Property: AXValidationError: textual content of the referenced element

Yes, WebKit could concatenate the text equivalents into the string for the API, or the API owners could consider a change.

@spectranaut
Copy link
Contributor

spectranaut commented Dec 22, 2022

@jcsteh's review?

I have a memory of discussing this in a meeting but I just looked through sept and oct meetings and didn't see anything. Should we agenda+ for a meeting in Jan, or do you remember discussing it?

@mrego
Copy link
Member Author

mrego commented Dec 22, 2022

BTW, filled issues on Firefox.

@spectranaut
Copy link
Contributor

Needs WPT test and link to webkit issue before merging.

@mrego
Copy link
Member Author

mrego commented Jan 10, 2023

Needs WPT test and link to webkit issue before merging.

WebKit already supports an ID reference list, so I guess we don't need an issue for that.

@cookiecrook
Copy link
Contributor

Thanks web-platform-tests/wpt#37856

@spectranaut, I think this can be merged now?

rniwa added a commit to rniwa/web-platform-tests that referenced this pull request Jan 11, 2023
rniwa added a commit to rniwa/web-platform-tests that referenced this pull request Jan 11, 2023
@spectranaut spectranaut merged commit 11c8909 into w3c:main Jan 11, 2023
github-actions bot added a commit that referenced this pull request Jan 11, 2023
SHA: 11c8909
Reason: push, by spectranaut

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@jcsteh
Copy link

jcsteh commented Jan 12, 2023

Sorry I didn't get around to reviewing this before it was merged. FWIW, this looks good to me.

rniwa added a commit to web-platform-tests/wpt that referenced this pull request Jan 12, 2023
@mrego mrego deleted the errormessage branch January 13, 2023 09:38
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jan 19, 2023
…rorMessageElement with ariaErrorMessageElements, a=testonly

Automatic update from web-platform-tests
Replace ARIA reflection attribute ariaErrorMessageElement with ariaErrorMessageElements (#37856)

This is WPT updates for w3c/aria#1802
--

wpt-commits: b2408e7967806c7ad7691dae706f60ab463d17e6
wpt-pr: 37856
jamienicol pushed a commit to jamienicol/gecko that referenced this pull request Jan 20, 2023
…rorMessageElement with ariaErrorMessageElements, a=testonly

Automatic update from web-platform-tests
Replace ARIA reflection attribute ariaErrorMessageElement with ariaErrorMessageElements (#37856)

This is WPT updates for w3c/aria#1802
--

wpt-commits: b2408e7967806c7ad7691dae706f60ab463d17e6
wpt-pr: 37856
aarongable pushed a commit to chromium/chromium that referenced this pull request Jul 19, 2023
Supported starting in WAI-ARIA 1.3.
w3c/aria#1802

Bug: 1403266
Change-Id: I5e3892e798f78acb8d99ff89d5bba76e12a9e2f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604466
Reviewed-by: David Tseng <[email protected]>
Reviewed-by: Dominick Ng <[email protected]>
Reviewed-by: Nektarios Paisios <[email protected]>
Reviewed-by: Xiaocheng Hu <[email protected]>
Commit-Queue: Aaron Leventhal <[email protected]>
Reviewed-by: Anastasia Helfinstein <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1172297}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should aria-errormessage be an ID reference list rather than a single reference?
7 participants

Follow Lee on X/Twitter - Father, Husband, Serial builder creating AI, crypto, games & web tools. We are friends :) AI Will Come To Life!

Check out: eBank.nz (Art Generator) | Netwrck.com (AI Tools) | Text-Generator.io (AI API) | BitBank.nz (Crypto AI) | ReadingTime (Kids Reading) | RewordGame | BigMultiplayerChess | WebFiddle | How.nz | Helix AI Assistant