Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aria-atomic has no default #1894

Merged
merged 1 commit into from
May 9, 2023
Merged

aria-atomic has no default #1894

merged 1 commit into from
May 9, 2023

Conversation

annevk
Copy link
Member

@annevk annevk commented Mar 23, 2023

Its computed value depends on its ancestors.

PR tracking

Check these when the relevant issue or PR has been made, OR after you have confirmed the
related change is not necessary (add N/A). Leave unchecked if you are unsure. Read the
Process Document or
Test Overview for more information.

  • Related Core AAM Issue/PR:
  • Related AccName Issue/PR:
  • Related APG Issue/PR:
  • Any other dependent changes?

Implementation tracking

  • "author MUST" tests:
  • "user agent MUST" tests:
  • Browser implementations (link to issue or when done, link to commit):
    • WebKit:
    • Gecko:
    • Blink:
  • Does this need AT implementations?

Diff

Its computed value depends on its ancestors.
@scottaohara
Copy link
Member

with this change, should we also not change or removing the word "default" in the following sentence:

If none of the ancestors have explicitly set aria-atomic is false,

@annevk
Copy link
Member Author

annevk commented Mar 23, 2023

I had a discussion with @cookiecrook about cases like this and what I think we want to do is distinguish between the DOM attribute and the AT property. Also to make it clear what computations are owned by the AT.

The DOM attribute is "true" or "false", invalid, or missing.

The AT property depends on the DOM attribute, the computed role, ancestor elements, etc.

I will take a stab at demonstrating what that would mean for the specification tomorrow by creating a draft PR for a single property.

@spectranaut
Copy link
Contributor

Just to be clear, this proposed change is editorial, correct? This is related to this re-thinking of the "default value" in #1896 but we aren't changing anything normative about the spec, or any behavior of the browser?

@annevk
Copy link
Member Author

annevk commented Apr 20, 2023

I'm not sure it's editorial (it's not a typo fix and arguably fixes an error), but it shouldn't have normative impact.

with this change, should we also not change or removing the word "default" in the following sentence:

Reworking that would be a larger change we'd make as part of what #1896 illustrates.

All this is making clear is that it doesn't have an intrinsic default. You need to read the prose to determine the default.

@cookiecrook
Copy link
Contributor

@annevk said, it's not technically "editorial", but it's clearly "errata" IMO.

@pkra pkra added the Agenda label May 9, 2023
@jnurthen jnurthen merged commit 7205d35 into w3c:main May 9, 2023
github-actions bot added a commit that referenced this pull request May 9, 2023
SHA: 7205d35
Reason: push, by jnurthen

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@annevk annevk deleted the annevk/aria-atomic branch May 10, 2023 06:55
YusukeHirao pushed a commit to YusukeHirao/markuplint that referenced this pull request May 19, 2023
jnurthen pushed a commit that referenced this pull request Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants

Follow Lee on X/Twitter - Father, Husband, Serial builder creating AI, crypto, games & web tools. We are friends :) AI Will Come To Life!

Check out: eBank.nz (Art Generator) | Netwrck.com (AI Tools) | Text-Generator.io (AI API) | BitBank.nz (Crypto AI) | ReadingTime (Kids Reading) | RewordGame | BigMultiplayerChess | WebFiddle | How.nz | Helix AI Assistant