-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the characteristics table of "caption" role #1975
Merged
spectranaut
merged 1 commit into
w3c:main
from
giacomo-petri:giacomo-petri-caption-role-patch
Aug 7, 2023
Merged
Updated the characteristics table of "caption" role #1975
spectranaut
merged 1 commit into
w3c:main
from
giacomo-petri:giacomo-petri-caption-role-patch
Aug 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s above Updated the Characteristics table for the caption role, reflecting the specs previously declared. Also sorted the list of "Required Accessibility Parent Roles" by alphabetical order.
spectranaut
approved these changes
Aug 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
github-actions bot
added a commit
that referenced
this pull request
Aug 7, 2023
SHA: 411bd50 Reason: push, by spectranaut Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
jnurthen
pushed a commit
that referenced
this pull request
Oct 10, 2023
while reviewing the specs for the caption role, I've realised that the characteristics table, in particular the "Required Accessibility Parent Roles" row, is not fully reflecting the requirements listed above. I've updated the "Required Accessibility Parent Roles" table content, adding also "group" and "radiogroup". I've also sorted the list of "Required Accessibility Parent Roles" by alphabetical order (both in text and in table). Closes: #1974
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
editorial
a change to an example, note, spelling, grammar, or is related to publishing or the repo
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Proposal:
while reviewing the specs for the caption role, I've realised that the characteristics table, in particular the "Required Accessibility Parent Roles" row, is not fully reflecting the requirements listed above.
Closes: #1974
Diff