Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollback restores ridless encoding trounced by sRD(simulcastOffer) #2797

Merged
merged 5 commits into from
Dec 13, 2022
Merged

Rollback restores ridless encoding trounced by sRD(simulcastOffer) #2797

merged 5 commits into from
Dec 13, 2022
+63 −4

Conversation

jan-ivar
Copy link
Member

@jan-ivar jan-ivar commented Nov 1, 2022 •
edited by pr-preview bot
Loading

Fixes @docfaraday PTAL.

Diff

@jan-ivar jan-ivar self-assigned this Nov 1, 2022
@docfaraday
Copy link
Contributor

Seems ok, I think.

aboba
aboba requested changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@aboba aboba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines 1913 - 1918: Can this be restructured as If.... then set like the rest of the PR?

@jan-ivar jan-ivar added the Needs Test Needs a WPT test label Dec 8, 2022
jan-ivar
jan-ivar commented Dec 13, 2022
View reviewed changes
@jan-ivar jan-ivar merged commit e8639d8 into w3c:main Dec 13, 2022
@jan-ivar jan-ivar deleted the rollbackencodings branch December 13, 2022 22:14
@jan-ivar jan-ivar mentioned this pull request Jan 4, 2023
Closed
@dontcallmedom dontcallmedom mentioned this pull request Nov 15, 2023
Merged
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aboba aboba aboba requested changes

@Orphis Orphis Awaiting requested review from Orphis

@alvestrand alvestrand Awaiting requested review from alvestrand

Assignees

@jan-ivar jan-ivar

Labels
Editors can integrate Needs Test Needs a WPT test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

What is the intended behavior of rollback of remote simulcast offer?
4 participants
@jan-ivar @docfaraday @aboba @alvestrand

Follow Lee on X/Twitter - Father, Husband, Serial builder creating AI, crypto, games & web tools. We are friends :) AI Will Come To Life!

Check out: eBank.nz (Art Generator) | Netwrck.com (AI Tools) | Text-Generator.io (AI API) | BitBank.nz (Crypto AI) | ReadingTime (Kids Reading) | RewordGame | BigMultiplayerChess | WebFiddle | How.nz | Helix AI Assistant