r86409 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r86408‎ \| r86409 \| r86410 >
Date:	16:04, 19 April 2011
Author:	happy-melon
Status:	ok (Comments)
Tags:
Comment:	(bug 28352) "blocked admins actually can't unblock themselves because it checks the wrong parameter". This doesn't need to be forward-ported as the entire blocking frontend is rewritten in 1.18.
Modified paths:	/branches/REL1_17/phase3/includes/specials/SpecialIpblocklist.php (modified) (history)

Diff [purge]

Index: branches/REL1_17/phase3/includes/specials/SpecialIpblocklist.php
—	—	@@ -77,7 +77,7 @@
78	78	$block = Block::newFromID( $this->id );
79	79	$user = User::newFromName( $block->mAddress );
80	80	} else {
81		~~- $user = User::newFromName( $ip );~~
	81	+ $user = User::newFromName( $this->ip );
82	82	}
83	83	$status = IPBlockForm::checkUnblockSelf( $user );
84	84	if ( $status !== true ) {

Follow-up revisions

Revision	Commit summary	Author	Date
r87353	1.17wmf1: MFT r85546, r86409, r86450, r86625, r86788, r86805, r86841, r86904,...	catrope	20:27, 3 May 2011

Comments

#Comment by contribs) 21:27, 2 May 2011

Adding 1.17wmf1 tag per BugTriage of Mon, April 18 2011:

http://bugzilla.wikimedia.org/28352
: Highest NEW self unblock with username does not work under 1.17
 * User having user right unblockself cannot unblock himself on wmf wikis.
 * Apparently fixed in trunk.
 * In which rev? If we know the rev we can merge it :)
 * mark will track down the revie

Status & tagging log

20:33, 3 May 2011 contribs) changed the tags for r86409 [removed: 1.17wmf1]
21:27, 2 May 2011 contribs) changed the tags for r86409 [added: 1.17wmf1]
12:39, 20 April 2011 contribs) changed the tags for r86409 [removed: 1.17]
16:26, 19 April 2011 contribs) changed the tags for r86409 [added: 1.17]
16:26, 19 April 2011 contribs) changed the status of r86409 [removed: new added: ok]